Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ManagerInterface response handling #581

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Improve ManagerInterface response handling #581

merged 3 commits into from
Dec 6, 2023

Conversation

sebastian-aranda
Copy link
Contributor

This PR makes some adjustments to the ManagerInterface methods to query LOVE-manager endpoints:

  • OLE callbacks more robust.
  • Moved response callbacks to function checkJSONResponse.

@sebastian-aranda sebastian-aranda changed the title Improve endpoints callback handling Improve ManagerInterface response handling Dec 4, 2023
mareuter
mareuter approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@mareuter mareuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@sebastian-aranda sebastian-aranda merged commit bdadd18 into develop Dec 6, 2023
1 check passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-41949 branch December 6, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareuter mareuter mareuter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastian-aranda @mareuter