Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust LOVE M2 force gradient coloring #592

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

sebastian-aranda
Copy link
Contributor

@sebastian-aranda sebastian-aranda commented Dec 27, 2023

This PR makes some adjustments to the M2.ForceGradiant component:

  • Color force gradient was inverted to show increment from left to right.
  • ForceGradiant was renamed to ForceGradient.
  • Force limits are now set automatically, same as for M1M3 component.

@sebastian-aranda sebastian-aranda force-pushed the tickets/DM-42320 branch 2 times, most recently from 88ef381 to 9973106 Compare January 8, 2024 14:02
Copy link

@teweitsai teweitsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment on lines 45 to 56
// minForceLimit: {
// type: 'number',
// description: 'Minimum force limit',
// isPrivate: false,
// default: 0,
// },
// maxForceLimit: {
// type: 'number',
// description: 'Maximum force limit',
// isPrivate: false,
// default: 1000,
// },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the comments if you do not need them any more.

@sebastian-aranda sebastian-aranda merged commit a61c3e5 into develop Jan 8, 2024
2 checks passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-42320 branch January 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants