Add RA, Dec and Rotator parameters to the ATDome component #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove and reorder imports Add PropTypes Use object destructuring for props and state
sebastian-aranda
force-pushed
the
tickets/DM-45690
branch
from
f6b413d to
b2b587f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks for adding the RA, Dec and Rotator position values in the ATDome display (
Auxtel/Dome). Along this the component code was improved.Also users have different preferences to show the format of the respective values, having degrees or hourly format (
hh:mm:ss). A couple functions were added for this purpose and also a component configuration was added to the ATDome display to allow users chose the respective format to show.