Add a button to log alarms from the AlarmsList and AlarmsTable components. #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
force-pushed
the
tickets/DM-46184
branch
from
ad37505 to
46c8c35
Compare
sebastian-aranda
force-pushed
the
tickets/DM-46184
branch
from
46c8c35 to
7ba2516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature to log alarms from Watcher components into the Narrativelog by using the
makeLogEntrycommand, alongside various other improvements and bug fixes. The most important refers to adding thelogAlarmmethod to the alarms redux actions. AlarmsTable and AlarmsList components were extended to support this new functionality.