Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LOVE night report email plain text format #254

Merged
merged 5 commits into from
May 31, 2024

Conversation

sebastian-aranda
Copy link
Contributor

@sebastian-aranda sebastian-aranda commented May 30, 2024

This PR fixes the plain format alternative on the arrange_nightreport_email function. It also adjusts some of the mail strings: welcoming, introduction and signing. Improved the way to render list values for the plain text format too.

@sebastian-aranda sebastian-aranda requested a review from wvreeven May 30, 2024 21:45
Copy link
Contributor

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastian-aranda sebastian-aranda merged commit 330187a into develop May 31, 2024
2 checks passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-44597 branch May 31, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants