Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cmd user creation for production deployments #280

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

sebastian-aranda
Copy link
Contributor

This PR extends the createusers command to include conditionals for user creation, so if a password is not defined when calling the command, the user won't be created. This way we can make the runserver.sh script to not include the cmd user pass, so this user is not created on the production deployments.

Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sebastian-aranda sebastian-aranda merged commit 0f1313c into develop Sep 6, 2024
2 checks passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-45973 branch September 6, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants