Tickets/dm41263: Parameterized OCPS index based on test environment #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareuter
requested changes
Oct 27, 2023
| print(f"\nEnabled to Offline; running {num_scripts} scripts") | ||
| asyncio.run(script_class.run()) | ||
| # Define the script arguments. | ||
| parser = argparse.ArgumentParser() |
There was a problem hiding this comment.
Line 93 to 105 could be made as function that returns the parsed args to avoid this being duplicated in the other scripts. Makes maintenance easier.
…ased on the test environment.
…ased on the test environment.
…he test environment.
rbovill
force-pushed
the
tickets/DM-41263
branch
from
b59a895 to
dc6827b
Compare
rbovill
force-pushed
the
tickets/DM-41263
branch
from
bd1d2d9 to
fe19a48
Compare
mareuter
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.