Merge pull request #147 from lsst-ts/tickets/DM-46201

Tickets/dm 46201: Support Summit Observing Weeks 37-38 of 2024
lsst-ts · Sep 23, 2024 · 0e38143 · 0e38143
2 parents fb2f764 + 0b9a517
commit 0e38143
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/doc/news/DM-46201.bugfix.rst b/doc/news/DM-46201.bugfix.rst
@@ -0,0 +1,2 @@
+Update BaseMakeCalibrations.take_image_type to correctly handle setting group_id whith the latest version of BaseScript.
+
diff --git a/python/lsst/ts/externalscripts/base_make_calibrations.py b/python/lsst/ts/externalscripts/base_make_calibrations.py
@@ -462,7 +462,7 @@ async def take_image_type(self, image_type, exp_times):
         """
 
         self.note = getattr(self.config, "note", None)
-        group_id = self.group_id if self.obs_id is None else self.obs_id
+        group_id = self.group_id if not self.obs_id else self.obs_id
 
         return tuple(
             [
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Update BaseMakeCalibrations.take_image_type to correctly handle setting group_id whith the latest version of BaseScript.