Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #139

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Main #139

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions doc/news/DM-45232.bugfix

This file was deleted.

2 changes: 0 additions & 2 deletions doc/news/DM-45232.bugfix.1

This file was deleted.

4 changes: 0 additions & 4 deletions doc/news/DM-45232.bugfix.2

This file was deleted.

2 changes: 0 additions & 2 deletions doc/news/DM-45232.bugfix.3

This file was deleted.

2 changes: 0 additions & 2 deletions doc/news/DM-45232.bugfix.4

This file was deleted.

1 change: 0 additions & 1 deletion doc/news/DM-45401.feature.rst

This file was deleted.

1 change: 0 additions & 1 deletion doc/news/DM-45406.feature.rst

This file was deleted.

25 changes: 25 additions & 0 deletions doc/version_history.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,31 @@ Version History

.. towncrier release notes start

v0.28.0 (2024-07-30)
====================

New Features
------------

- Add new TakeComCamGuiderImage script, designed to test ComCam guider mode. (`DM-45401 <https://rubinobs.atlassian.net/browse/DM-45401>`_)
- Add new TakePTCFlatsComcam script to take PTC flats with ComCam while scanning electrometer. (`DM-45406 <https://rubinobs.atlassian.net/browse/DM-45406>`_)


Bug Fixes
---------

- In ``take_ptc_flats_comcam`` add ``StateTransition`` usage to Camera instance. (`DM-45232 <https://rubinobs.atlassian.net/browse/DM-45232>`_)
- In ``base_make_calibrations.py``, fix issue with ``take_image_type`` method trying to set ``self.group_id``.

This is a class property and cannot be changed.
Instead, use a local variable.Add your info here (`DM-45232 <https://rubinobs.atlassian.net/browse/DM-45232>`_)
- In ``take_ptc_flats_comcam`` add a setup_instrument to change filter.

This is needed because ComCam is still returning an error when we tell it to select a filter that is already selected. (`DM-45232 <https://rubinobs.atlassian.net/browse/DM-45232>`_)
- In take_ptc_flats_comcam.py, fix issue with take_image_type method trying to set self.group_id. (`DM-45232 <https://rubinobs.atlassian.net/browse/DM-45232>`_)
- In ``take_ptc_flats_comcam`` remove default value from schema. (`DM-45232 <https://rubinobs.atlassian.net/browse/DM-45232>`_)


v0.27.6 (2024-07-15)
====================

Expand Down
Loading