Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tcs_ready_to_take_data integration for on-sky images #149

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

iglesu
Copy link
Contributor

@iglesu iglesu commented Oct 13, 2024

Integrated the tcs_ready_to_take_data method across scripts responsible for taking on-sky images, specifically for image types: OBJECT, ENTEST, ACQ, CWFS

Before I keep going I want to make sure I'm not deviating from the intended development objectives. Please see unit test in standardscripts draft PR #229

@iglesu iglesu requested a review from tribeiro October 13, 2024 20:52
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, my only comment is with regard to the news fragment that needs to be more specific.

@@ -0,0 +1,2 @@
Extend TCS readiness check to other image types beyond OBJECT.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make the news fragment more relevant explaining the changes you are introducing.

@iglesu iglesu marked this pull request as ready for review October 18, 2024 19:16
@iglesu iglesu force-pushed the tickets/DM-46179 branch 2 times, most recently from e8f8e01 to a06cdcb Compare October 21, 2024 16:40
Integrated the `tcs_ready_to_take_data` method across scripts
responsible for taking on-sky images, specifically for image types:
OBJECT, ENTEST, ACQ, CWFS
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@iglesu iglesu merged commit a2bf33e into develop Oct 25, 2024
2 checks passed
@iglesu iglesu deleted the tickets/DM-46179 branch October 25, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants