Tickets/dm 46175 #24
Tickets/dm 46175 #24
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -19,7 +19,8 @@ | |||
| "# Times Square replaces this cell with the user's parameters.\n", | |||
There was a problem hiding this comment.
Line #6. instrument = 'lsstcomcamsim' # Which instrument to query for data (consdb)
NightLog should report on ALL instruments. It shouldn't require the user to pick just one.
Reply via ReviewNB
There was a problem hiding this comment.
Refactored to accommodate this
| @@ -19,7 +19,8 @@ | |||
| "# Times Square replaces this cell with the user's parameters.\n", | |||
There was a problem hiding this comment.
Line #5. from lsst.summit.utils import ConsDbClient
ConsDB specialized code should be refactored into source_adapters.py
Reply via ReviewNB
There was a problem hiding this comment.
This is an external-to-our-repository package: https://github.com/lsst-sitcom/summit_utils/blob/main/python/lsst/summit/utils/consdbClient.py
| @@ -19,7 +19,8 @@ | |||
| "# Times Square replaces this cell with the user's parameters.\n", | |||
There was a problem hiding this comment.
Line #29. CONSDB_URL = "http://consdb-pq.consdb:8080/consdb" # Don't use this one
Is this always the same for all environments (tucson-teststand, summit, usdf)? If not, it should be set based upon the EXTERNAL_INSTANCE_URL env var.
Reply via ReviewNB
There was a problem hiding this comment.
Yes, this is the same for both summit and usdf. I also have the note 'don't use this' because some updates need to be made to ConsDbClient to accept headers towards authenticating in a copacetic way according to sqre.
Reference to consdb usage here: https://rubinobs.atlassian.net/wiki/spaces/~ktl/pages/55377993/ConsDB+Usage#ConsDBUsage-ConnectionInformation
Added DDV,
Added accessing data from ConsDb for the plots requested. Some of the data still needs clarified.
We should talk about how to merge notebooks... It seemed unsuitable to rebase off of prototype, but we should discuss.