Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype into Develop 9/19 #26

Merged
merged 71 commits into from
Sep 24, 2024
Merged

Prototype into Develop 9/19 #26

merged 71 commits into from
Sep 24, 2024

Conversation

Vebop
Copy link
Contributor

@Vebop Vebop commented Sep 19, 2024

Almanac, Exposure log, Narrative Log, backend classy, observation gaps,
DDV Link, Accessing data from consdb to plot, etc

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

notebooks_tsqr/NightLog.ipynb Show resolved Hide resolved
notebooks_tsqr/NightLog.ipynb Show resolved Hide resolved
notebooks_tsqr/NightLog.ipynb Show resolved Hide resolved
notebooks_tsqr/NightLog.ipynb Show resolved Hide resolved
notebooks_tsqr/NightLog.ipynb Show resolved Hide resolved
notebooks_tsqr/NightLog.ipynb Show resolved Hide resolved
notebooks_tsqr/NightLog.ipynb Show resolved Hide resolved
notebooks_tsqr/consdb/access_consdb.ipynb Show resolved Hide resolved
notebooks_tsqr/consdb/assorted_plots.ipynb Show resolved Hide resolved
notebooks_tsqr/exposurelog.HIDE_yaml Outdated Show resolved Hide resolved
python/lsst/ts/logging_and_reporting/exceptions.py Outdated Show resolved Hide resolved
python/lsst/ts/logging_and_reporting/reports.py Outdated Show resolved Hide resolved
python/lsst/ts/logging_and_reporting/source_adapters.py Outdated Show resolved Hide resolved
python/lsst/ts/logging_and_reporting/source_adapters.py Outdated Show resolved Hide resolved
python/lsst/ts/logging_and_reporting/utils.py Outdated Show resolved Hide resolved
@Vebop Vebop marked this pull request as ready for review September 24, 2024 20:01
@Vebop Vebop requested a review from pothiers September 24, 2024 20:02
day_obs:
type: string
description: Date on which to query
default: '2024-06-26'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should change the default. utils.get_datetime_from_day_obs_str will let you use TODAY, TOMORROW, YESTERDAY also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, however because of the kernel issues I cannot yet use anything in our own lsst package yet while being in the lsst kernel, as my pages for consdb are.

Copy link
Collaborator

@pothiers pothiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we got everything from yesterdays pair review

@Vebop Vebop merged commit 809427b into develop Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants