Tickets/dm 41339 #120
Merged
Tickets/dm 41339 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
As I mentioned to you on slack, I think you hit an old bug with the MTCS._slew_to method that still has stop_before_slew defaulting to True. Please, change it to False and then you should be able to assert that stopTracking is not awaited in the MTCS test as well.
For the record, the change is here:
Everything else looks great! thanks!
doc/news/DM-41339.feature.rst
Outdated
| @@ -0,0 +1 @@ | |||
| In ``base_tcs.py`` add a ``slew_sphem_target`` method that allow both telescopes to track a target based on an ephemeris file. | |||
There was a problem hiding this comment.
typo slew_sphem_target -> slew_ephem_target
dsanmartim
force-pushed
the
tickets/DM-41339
branch
3 times, most recently
from
18e05cc to
123e992
Compare
dsanmartim
force-pushed
the
tickets/DM-41339
branch
from
123e992 to
d895d3c
Compare
…fault parameter to False.
dsanmartim
force-pushed
the
tickets/DM-41339
branch
from
d895d3c to
d49a85d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the first try of the
slew_ephem_targetmethod.