Tickets/dm 41806 #127
Merged
Tickets/dm 41806 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Looks good! I only have a couple comments I hope you consider before I can approve it.
Also, can you please fix the GitHub lint action? you need to update this with the following:
$CONDA/bin/conda install -c lsstts -c conda-forge pre-commit ts-pre-commit-config python=3.11 -y
| self.log.debug("Closing dome dropout door...") | ||
| await self.rem.atdome.cmd_moveShutterDropoutDoor.set_start( | ||
| open=False, timeout=self.open_dropout_door_time | ||
| ) |
There was a problem hiding this comment.
Need to wait for the dropout to close right?
There was a problem hiding this comment.
Alright. Take a look to see if it is ok now.
There was a problem hiding this comment.
Nice of you to update this, but this needs to be deprecated.
dsanmartim
force-pushed
the
tickets/DM-41806
branch
from
86815ab to
667e141
Compare
dsanmartim
force-pushed
the
tickets/DM-41806
branch
from
667e141 to
06d325b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tiago,
I have the unit test passing, but I realized that some auxiliary methods added to the mock modules may be unnecessary. Waiting for your feedback to merge it and finish the corresponding SAL scripts.