Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-45219 #144

Merged
merged 2 commits into from
Jul 15, 2024
Merged

tickets/DM-45219 #144

merged 2 commits into from
Jul 15, 2024

Conversation

elanaku
Copy link
Contributor

@elanaku elanaku commented Jul 12, 2024

Added new configs to ATCalsys.yaml for the AT PTC curves.

@elanaku elanaku requested review from tribeiro and parfa30 July 12, 2024 22:11
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please, see my inline comment before merging.

Also, please, add the news fragment.

electrometer_integration_time: 0.1
electrometer_mode: CURRENT
electrometer_range: -1
use_fiberspectrograph: true
Copy link
Member

@tribeiro tribeiro Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two flags are currently not used. I think Parker is adding this as part of another PR, please remove them.

@elanaku elanaku force-pushed the tickets/DM-45219 branch from 6df0f69 to acf34e3 Compare July 15, 2024 20:17
@elanaku elanaku merged commit 45be55f into develop Jul 15, 2024
5 checks passed
@elanaku elanaku deleted the tickets/DM-45219 branch July 15, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants