DM-47414: In base_camera.py, remove support for splitting guider ROI … #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfanning
force-pushed
the
tickets/DM-47414
branch
3 times, most recently
from
2573b5a to
cb5ce00
Compare
tribeiro
approved these changes
Dec 3, 2024
doc/news/DM-47414.removal.rst
Outdated
| @@ -0,0 +1,5 @@ | |||
| :::::::::::::: | |||
There was a problem hiding this comment.
Please remove these 3 header lines from the news fragments. It should contain only the changelog.
| roiSpec=roi_spec_json, | ||
| timeout=self.long_timeout, | ||
| ) | ||
| self.log.info(f"ROISpec(len:{len(roi_spec_json)}) fits in one command.") |
There was a problem hiding this comment.
Please remove this log statement here as it is no longer relevant.
…specs into multiple part. Size limit no longer exists.
… behavior between long and short ROI specs.
kfanning
force-pushed
the
tickets/DM-47414
branch
from
cb5ce00 to
f10e809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…specs into multiple part. Size limit no longer exists.