tickets/DM-47223: Prepare _wait_hard_point_test_ok method in MTCS for parallelization #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
reviewed
Nov 15, 2024
doc/news/DM-47223.feature.rst
Outdated
| @@ -0,0 +1,2 @@ | |||
| Update ``_wait_hard_point_test_ok`` method in ``MTCS`` to be compatible with | |||
| concurrent executions. | |||
There was a problem hiding this comment.
For documentation in general we adopted something called "semantic line break". Basically it means that each phrase should be in one line. Please, make sure this is all in one line.
| hp_test_state = MTM1M3.HardpointTest( | ||
| ( | ||
| await self.rem.mtm1m3.evt_hardpointTestStatus.next( | ||
| await self.rem.mtm1m3.evt_hardpointTestStatus.aget( | ||
| flush=False, timeout=self.timeout_hardpoint_test_status |
There was a problem hiding this comment.
aget does not have a flush parameter.
| @@ -1302,6 +1305,10 @@ async def _wait_hard_point_test_ok(self, hp: int) -> None: | |||
| else: | |||
| self.log.info(f"Hard point {hp} test state: {hp_test_state!r}.") | |||
|
|
|||
| await self.rem.mtm1m3.evt_heartbeat.next( | |||
There was a problem hiding this comment.
you might want to wrap this await here with a try/except and catch and treat timeout errors. It might be hard for users to understand why there is a heartbeat timeout coming from this loop. Consider something like:
try:
await self.rem.mtm1m3.evt_heartbeat.next(...)
expect asyncio.TimeoutError:
raise RuntimeError(f"No heartbeat received from M1M3 in the last {self.timeout_hardpoint_test_status}s while waiting for hard point data information. Check CSC liveliness.")
There was a problem hiding this comment.
Agreed. I'm also adding a unit test for this case.
Update the wait method for hardpoint tests to be ok in order to make it compatible with concurrent executions. Using next will pop the data from the queue so it might happen that one execution will “steal” the event for the other and vice versa. This commit changes next to aget and adds a sleep to avoid that.
cvillalon
force-pushed
the
tickets/DM-47223
branch
from
9c00be6 to
66357a2
Compare
tribeiro
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the wait method for hardpoint tests to be ok in order to make it compatible with concurrent executions.
Using
nextwill pop the data from the queue so it might happen that one execution will “steal” the event for the other and vice versa. This PR changesnexttoagetand adds asleepto avoid that.