Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rotations of donut stamps from calculate step to save donutStamps. #203

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

jbkalmbach
Copy link
Member

No description provided.

@jbkalmbach jbkalmbach force-pushed the tickets/DM-40867 branch 4 times, most recently from ac6612c to 7005776 Compare October 9, 2023 23:45
@jbkalmbach jbkalmbach marked this pull request as ready for review October 9, 2023 23:55
@jbkalmbach jbkalmbach requested a review from suberlak October 10, 2023 00:11
@jbkalmbach jbkalmbach force-pushed the tickets/DM-40867 branch 3 times, most recently from 082e43a to cd54490 Compare October 10, 2023 18:37
Copy link
Contributor

@suberlak suberlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, please have a look, thanks for update!

python/lsst/ts/wep/task/calcZernikesTask.py Show resolved Hide resolved
python/lsst/ts/wep/task/calcZernikesTask.py Show resolved Hide resolved
python/lsst/ts/wep/task/calcZernikesTask.py Outdated Show resolved Hide resolved
tests/task/test_calcZernikesTaskCwfs.py Show resolved Hide resolved
@suberlak suberlak self-requested a review October 11, 2023 18:12
@jbkalmbach jbkalmbach force-pushed the tickets/DM-40867 branch 6 times, most recently from 9728b07 to b7c626b Compare October 12, 2023 22:22
@jbkalmbach
Copy link
Member Author

Since this will break convergence with https://github.com/lsst-ts/ts_phosim and move us completely to ts_imsim we have conducted studies to show that there is a similar level of convergence between ts_phosim and ts_imsim results. See https://jira.lsstcorp.org/browse/DM-40867 for plots.

@jbkalmbach jbkalmbach merged commit d02ea46 into develop Oct 17, 2023
@jbkalmbach jbkalmbach deleted the tickets/DM-40867 branch October 17, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants