tickets/DM-47163: Cut on fraction of bad pixels; run stamp selection during CalcZernikeTask by default #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during calcZernikes.
jfcrenshaw
requested review from
jmeyers314 and
suberlak
and removed request for
jmeyers314
suberlak
approved these changes
Oct 26, 2024
| @@ -62,13 +68,17 @@ class DonutStampSelectorTaskConfig(pexConfig.Config): | |||
| default=3.5, | |||
| doc=str("The entropy threshold to use (keep donuts only below the threshold)."), | |||
| ) | |||
| maxFracBadPixels = pexConfig.Field( | |||
| dtype=float, | |||
| default=0.0, | |||
There was a problem hiding this comment.
It would be really good to run that against even a simulation / early real data. I'm worried that with such strict requirement we may get nothing passing atm.
There was a problem hiding this comment.
Working on this
There was a problem hiding this comment.
Checked this works
|
New failures arose after Adding frac_bad_pix to calcZernikes output. Also tests on ComCam data revealed that some pixel fractions are > 1, which shouldn't happen. Will investigate soon. |
jfcrenshaw
added a commit
that referenced
this pull request
Oct 28, 2024
* Change zernikes output to QTable. * Add roundtrip for VisitInfo <-> dict * Remove VisitInfo from CutOutDonutsScienceSensorTask connections. Update addVisitInfoToCatTable test. * Add round trip dict to visit info test. * Add exposure time to visit_info dict. Add all keys to round trip test. * Add necessary metadata to tasks downstream of donutTables. * Update production pipeline for ComCam. * Enable RubinTV upload on production pipelines * Remove MJD assertion between intra and extra donut stamps. * tickets/DM-46117: single-side-of-focus pipeline (#273) * tickets/DM-47163: Cut on fraction of bad pixels; run stamp selection during CalcZernikeTask by default (#277) * Switch to new ISR task * Fixed bug where original mask bits aren't persisted in stamps. * Tickets/DM-47188: Fix bug where CalcZernikesTask fails if number of intra/extra stamps isn't equal (#279) * Increase stamp size in rapid analysis pipeline so donut edges aren't clipped (#280) --------- Co-authored-by: J. Bryce Kalmbach <[email protected]> Co-authored-by: Josh Meyers <[email protected]> Co-authored-by: Merlin Fisher-Levine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.