Enable CutOutDonutsScienceSensorTask to operate for a pair with same-sign focusZ. #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CutOutDonutsScienceSensorTaskwas previously written to require a pair of exposures with focusZ of opposite signs (i.e., one positive and one negative). If both focusZ had the same sign, it worried you had passed two exposures on the same side of focus, and raised an exception.Apparently this was not desired and caused problems on night of 20241028. This PR removes this check and simply assigns the lower focusZ to intrafocal