-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tickets/DM-47480: sparse Zernike estimation #290
Conversation
1536ae0
to
144f15f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! LGTM.
@@ -5,21 +5,24 @@ tasks: | |||
class: lsst.ts.wep.task.generateDonutDirectDetectTask.GenerateDonutDirectDetectTask | |||
config: | |||
donutSelector.useCustomMagLimit: True | |||
donutSelector.sourceLimit: 5 | |||
donutSelector.sourceLimit: 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we already change these? Was that just on this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is because I copied the ComCam config over to the ComCamSim config to keep them the same. I guess we forgot to update this number when we made this change in ComCam.
No description provided.