Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-47480: sparse Zernike estimation #290

Merged
merged 7 commits into from
Nov 17, 2024
Merged

Conversation

jfcrenshaw
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@jmeyers314 jmeyers314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! LGTM.

@@ -5,21 +5,24 @@ tasks:
class: lsst.ts.wep.task.generateDonutDirectDetectTask.GenerateDonutDirectDetectTask
config:
donutSelector.useCustomMagLimit: True
donutSelector.sourceLimit: 5
donutSelector.sourceLimit: 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we already change these? Was that just on this branch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is because I copied the ComCam config over to the ComCamSim config to keep them the same. I guess we forgot to update this number when we made this change in ComCam.

@jfcrenshaw jfcrenshaw merged commit caf6714 into develop Nov 17, 2024
4 checks passed
@jfcrenshaw jfcrenshaw deleted the tickets/DM-47480 branch November 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants