Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the plotPsfZernTask in the pipelines #294

Merged
merged 3 commits into from
Nov 25, 2024
Merged

add the plotPsfZernTask in the pipelines #294

merged 3 commits into from
Nov 25, 2024

Conversation

LR-inaf
Copy link
Contributor

@LR-inaf LR-inaf commented Nov 22, 2024

No description provided.

Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please remove the checkpoint files and the addition in gitignore.

.gitignore Outdated
@@ -36,3 +36,4 @@ pytest_session.txt

# Existing Phosim Donut Templates
policy/cwfs/donutTemplateData/phosimTemplates/
.ruff.toml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add this here. We have a custom file for this repository to run with ts_precommit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to remove these three lines?

Copy link
Collaborator

@teweitsai teweitsai Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .ruff.toml was added by the ts_precommit in a certain version when we began to use the toml.
For example, https://github.com/lsst-ts/ts_m2gui/blob/develop/.gitignore#L147-L148

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the .ruff.toml. ts_wep uses a slightly different one than the standard ts_precommit ruff file. We can work on updating ts_wep so we don't need that but that should be a separate issue.

@@ -0,0 +1,1935 @@
.. py:currentmodule:: lsst.ts.wep
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file please.

@@ -0,0 +1,42 @@
description: donut viz pipeline tasks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this checkpoint file.

@@ -0,0 +1,40 @@
description: rapid analysis pipeline for ComCam w/ danish zernike estimation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the checkpoint files.

@@ -0,0 +1,45 @@
description: rapid analysis pipeline for ComCam
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the checkpoint file.

@@ -0,0 +1,373 @@
# This file is part of ts_wep.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove checkpoint file

@@ -0,0 +1,304 @@
# This file is part of ts_wep.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove checkpoint file

@jbkalmbach jbkalmbach self-requested a review November 25, 2024 17:59
Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@LR-inaf LR-inaf merged commit 96089ba into develop Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants