-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the plotPsfZernTask in the pipelines #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please remove the checkpoint files and the addition in gitignore.
.gitignore
Outdated
@@ -36,3 +36,4 @@ pytest_session.txt | |||
|
|||
# Existing Phosim Donut Templates | |||
policy/cwfs/donutTemplateData/phosimTemplates/ | |||
.ruff.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add this here. We have a custom file for this repository to run with ts_precommit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to remove these three lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .ruff.toml
was added by the ts_precommit
in a certain version when we began to use the toml
.
For example, https://github.com/lsst-ts/ts_m2gui/blob/develop/.gitignore#L147-L148
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the .ruff.toml
. ts_wep
uses a slightly different one than the standard ts_precommit
ruff file. We can work on updating ts_wep
so we don't need that but that should be a separate issue.
@@ -0,0 +1,1935 @@ | |||
.. py:currentmodule:: lsst.ts.wep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file please.
@@ -0,0 +1,42 @@ | |||
description: donut viz pipeline tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this checkpoint file.
@@ -0,0 +1,40 @@ | |||
description: rapid analysis pipeline for ComCam w/ danish zernike estimation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the checkpoint files.
@@ -0,0 +1,45 @@ | |||
description: rapid analysis pipeline for ComCam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the checkpoint file.
@@ -0,0 +1,373 @@ | |||
# This file is part of ts_wep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove checkpoint file
@@ -0,0 +1,304 @@ | |||
# This file is part of ts_wep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove checkpoint file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
No description provided.