Danish joint fit #300
Merged
Danish joint fit #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeyers314
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
LGTM! One small comment. I guess you need for #299 to merge and rebase before merging this one?
| @@ -248,7 +297,7 @@ def _estimateSingleZk( | |||
| dy, | |||
| fwhm, | |||
| zkFit, | |||
| sky_level=backgroundStd, | |||
| sky_level=backgroundStd**2, | |||
jfcrenshaw
force-pushed
the
danishJointFit
branch
from
82d2245 to
51b0f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Danish can now jointly fit a pair of donuts, rather than fitting individually and then averaging Zernikes. I think this is likely more robust, e.g. I think it is more likely to properly distinguish astigmatism from DCR. Futhermore, it appears to be about the same speed as the fit-individually-and-average method. I have, therefore, made the joint-fit the new default.