Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looser convergence threshold for Danish #301

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

jfcrenshaw
Copy link
Collaborator

No description provided.

@jfcrenshaw jfcrenshaw requested a review from suberlak December 5, 2024 20:55
Copy link
Contributor

@suberlak suberlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for quick update! Is there any test that could validate these criteria?

@@ -12,7 +12,7 @@ Version History
13.0.5
-------------

* Set saveHistory=True in the Danish production pipeline
* Set saveHistory=True and looser convergence criteria in the Danish production pipeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"loosen" ? (Or set the criteria to be more loose)?

@suberlak suberlak self-requested a review December 5, 2024 21:20
Copy link
Contributor

@suberlak suberlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@jfcrenshaw jfcrenshaw merged commit 8b1ded2 into develop Dec 5, 2024
4 checks passed
@jfcrenshaw jfcrenshaw deleted the looser-danish-convergence branch December 5, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants