DM-47730: add test to guard against unexpected NoWorkFound and predicted-only datasets #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are useful for tests and debugging; we don't want to hide them.
TallJimbo
force-pushed
the
tickets/DM-47730
branch
2 times, most recently
from
d5cfaa9 to
0241dd7
Compare
This hasn't worked since the lower-level mocking functionality was rewritten for usage in ci_middleware.
TallJimbo
force-pushed
the
tickets/DM-47730
branch
from
0241dd7 to
5c13ae8
Compare
eigerx
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
This appears to do a great job of exactly what it says. I appreciate the use of the QuantumProvenanceGraph in tests! And removing the defunct $mock option, while not technically in the scope of this PR, seems like a good call also. A question: where does the saved quantum graph go? And, when does it get deleted?
Love to see NoWorkFound cases covered by the QPG; thanks for asking me to review.
It just goes into the root directory of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.