DM-45928: add parallel CTI and add serial/parallel turnoff calculations to DeferredChargeCalib #280
Conversation
Alex-Broughton
force-pushed
the
tickets/DM-45928
branch
2 times, most recently
from
1f0f97f to
d6cc862
Compare
Alex-Broughton
force-pushed
the
tickets/DM-45928
branch
3 times, most recently
from
28fab7f to
6fbf70c
Compare
Alex-Broughton
force-pushed
the
tickets/DM-45928
branch
4 times, most recently
from
67580da to
fbdd3ee
Compare
Alex-Broughton
force-pushed
the
tickets/DM-45928
branch
4 times, most recently
from
7b3b1c5 to
3825f88
Compare
Alex-Broughton
force-pushed
the
tickets/DM-45928
branch
2 times, most recently
from
5b92870 to
3b40c4d
Compare
| @@ -37,153 +38,231 @@ class CpCtiSolveTaskTestCase(lsst.utils.tests.TestCase): | |||
| def setUp(self): | |||
| self.camera = IsrMock().getCamera() | |||
|
|
|||
There was a problem hiding this comment.
Where did these data come from?
There was a problem hiding this comment.
I think the originals were just empirical values I had during testing, and suspect the same of the updated values.
| self.assertEqual( | ||
| calib.signals[ampName][-1] - calib.signals[ampName][-2], | ||
| calib.parallelCtiTurnoffSamplingErr[ampName], | ||
| ) |
There was a problem hiding this comment.
Where did the expectations come from above?
There was a problem hiding this comment.
I added SerialOscanMeansD, which is roughly 20*SerialOscanMeansC. The code should have correctly calculated that the serial turnoff is at the signal level associated with C and the serial overscan turnoff sampling error is roughly (signal D - signal B) / 2.
I also set all the parallel overscan means to the same thing at all signal levels (which is similar to never sampling the turnoff, which is common in real data). In that case it shoul set the parallel turnoff to the last value and the parallel turnoff sampling error should be the spacing between the last value and the second-to-last value.
I can add a comment to clarify this.
| @@ -37,153 +38,231 @@ class CpCtiSolveTaskTestCase(lsst.utils.tests.TestCase): | |||
| def setUp(self): | |||
| self.camera = IsrMock().getCamera() | |||
|
|
|||
There was a problem hiding this comment.
I think the originals were just empirical values I had during testing, and suspect the same of the updated values.
Alex-Broughton
force-pushed
the
tickets/DM-45928
branch
from
3b40c4d to
3d21fb2
Compare
Alex-Broughton
force-pushed
the
tickets/DM-45928
branch
from
3d21fb2 to
aadd571
Compare
Alex-Broughton
force-pushed
the
tickets/DM-45928
branch
from
aadd571 to
9e11bcd
Compare
No description provided.