DM-48019: Some drp_pipe pipelines use sourceTable_visit in the analyzePreSourceTableCore task instead of preSourceTable_visit

[enourbakhsh]

No description provided.

[enourbakhsh]

I don't think we need to provide data here, right? Isn't inputName enough? Here is where the connections are defined for this task:
https://github.com/lsst/analysis_tools/blob/e452f7d79f336b7d8be42b4ac7a24ac7647eb724/python/lsst/analysis/tools/tasks/sourceTableVisitAnalysis.py#L35

class SourceTableVisitAnalysisConnections(
    AnalysisBaseConnections,
    dimensions=("visit", "band"),
    defaultTemplates={"inputName": "sourceTable_visit"},
):
    data = ct.Input(
        doc="Visit based source table to load from the butler",
        name="sourceTable_visit",
        storageClass="ArrowAstropy",
        dimensions=("visit", "band"),
        deferLoad=True,
    )

    camera = ct.PrerequisiteInput(
        doc="Input camera to use for focal plane geometry.",
        name="camera",
        storageClass="Camera",
        dimensions=("instrument",),
        isCalibration=True,
    )

[enourbakhsh]

Changed the analysis_tools connection class to the following on this ticket:

class SourceTableVisitAnalysisConnections(
    AnalysisBaseConnections,
    dimensions=("visit", "band"),
    defaultTemplates={"inputName": "sourceTable_visit"},
):
    data = ct.Input(
        doc="Visit based source table to load from the butler",
        name="{inputName}",  # Changed this line!
        storageClass="ArrowAstropy",
        dimensions=("visit", "band"),
        deferLoad=True,
    )

    camera = ct.PrerequisiteInput(
        doc="Input camera to use for focal plane geometry.",
        name="camera",
        storageClass="Camera",
        dimensions=("instrument",),
        isCalibration=True,
    )

[yalsayyad]

Right, the only reason we'd need to define data is if it was involved in a contract at the end of the pipeline yaml.

[yalsayyad]

Right, the only reason we'd need to define data is if it was involved in a contract at the end of the pipeline yaml.

[yalsayyad]

Please also delete the unnecessary overrides:

• https://github.com/lsst/drp_pipe/blob/main/pipelines/LSSTComCamSim/nightly-validation.yaml#L12
• https://github.com/lsst/drp_pipe/blob/main/pipelines/LSSTComCam/nightly-validation.yaml#L24

[enourbakhsh]

Please also delete the unnecessary overrides:

• https://github.com/lsst/drp_pipe/blob/main/pipelines/LSSTComCamSim/nightly-validation.yaml#L12
• https://github.com/lsst/drp_pipe/blob/main/pipelines/LSSTComCam/nightly-validation.yaml#L24

Done!