DM-45545: Change autocast to handle numpy types #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In numpy 2 numpy ints and floats stringify to np.int64/float64 and they can not be read back in again. This change forces numeric types to be converted to standard python types.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 86.00% 86.01% +0.01%
==========================================
Files 46 46
Lines 3645 3648 +3
==========================================
+ Hits 3135 3138 +3
Misses 510 510 ☔ View full report in Codecov by Sentry. |
andy-slac
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In numpy 2 numpy ints and floats stringify to np.int64/float64 and they can not be read back in again. This change forces numeric types to be converted to standard python types.
Checklist
doc/changes