DM-47526: Add allow_missing_bands for multiband object fitting #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
force-pushed
the
tickets/DM-47526
branch
from
c2f8d25 to
1f908ed
Compare
fred3m
approved these changes
Jan 15, 2025
Comment on lines
+381
to
+387
| catexp = CatalogExposureInputs( | ||
| catalog=afwTable.SourceCatalog(), | ||
| exposure=None, | ||
| table_psf_fits=astropy.table.Table(), | ||
| dataId=dataId.from_simple(dataId_band, universe=dataId.universe), | ||
| id_tract_patch=id_tp, | ||
| ) |
There was a problem hiding this comment.
I wonder if it would be useful to have an EmptyExposureInputs class that inherits from CatalogExposureInputs but only takes a dataId and id_tract_patch. This would make it clear here that this is just a placeholder.
There was a problem hiding this comment.
Hmm, it's possible. I was also consider just implementing an is_dummy/is_placeholder method that just returns len(self.catalog) == 0. I decided to defer committing to a particular interface until I have a clearer understanding of the benefits/drawbacks of dummy data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.