DM-47060: Add attempted dipole classification of object to APDB #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
requested changes
Nov 27, 2024
| - name: dipoleFitAttempted | ||
| "@id": "#DiaSource.dipoleFitAttempted" | ||
| datatype: boolean | ||
| description: Attempted classification of object to be a dipole. |
There was a problem hiding this comment.
Suggested change
| description: Attempted classification of object to be a dipole. | |
| description: Attempted to fit a dipole model to this source. |
| @@ -2015,6 +2015,10 @@ tables: | |||
| "@id": "#DiaSource.isDipole" | |||
| datatype: boolean | |||
| description: Object determined to be a dipole. | |||
There was a problem hiding this comment.
Suggested change
| description: Object determined to be a dipole. | |
| description: Source well fit by a dipole. |
Comment on lines
6783
to
6788
| description: Flag indicating diaSource is classified as a dipole | ||
| description: Classification of diaSource as a dipole. | ||
| fits:tunit: | ||
| - name: dipoleFitAttempted | ||
| "@id": "#DiaSource.dipoleFitAttempted" | ||
| datatype: boolean | ||
| description: Attempted classification of object to be a dipole. |
There was a problem hiding this comment.
Please remove the change to this file: the dp02 schema was set when it was released, and shouldn't change after.
| @@ -7801,7 +7801,12 @@ tables: | |||
| - name: isDipole | |||
| "@id": "#DiaSource.isDipole" | |||
| datatype: boolean | |||
| description: Flag indicating diaSource is classified as a dipole. | |||
| description: Classification of diaSource as a dipole. | |||
There was a problem hiding this comment.
Suggested change
| description: Classification of diaSource as a dipole. | |
| description: Source well fit by a dipole. |
| - name: dipoleFitAttempted | ||
| "@id": "#DiaSource.dipoleFitAttempted" | ||
| datatype: boolean | ||
| description: Attempted classification of object to be a dipole. |
There was a problem hiding this comment.
Suggested change
| description: Attempted classification of object to be a dipole. | |
| description: Attempted to fit a dipole model to this source. |
abudlong
force-pushed
the
tickets/DM-47060
branch
from
31b82c7 to
73affc1
Compare
abudlong
force-pushed
the
tickets/DM-47060
branch
from
73affc1 to
46b25b9
Compare
parejkoj
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.