Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "sort" param for sorting LDAP multivalued attributes (#171) #181

Merged
merged 2 commits into from
Nov 18, 2024
Merged

add "sort" param for sorting LDAP multivalued attributes (#171) #181

merged 2 commits into from
Nov 18, 2024

Conversation

davidcoutadeur
Copy link

Closes #171

@davidcoutadeur davidcoutadeur added the enhancement New feature or request label Nov 4, 2024
@davidcoutadeur davidcoutadeur added this to the 0.6 milestone Nov 4, 2024
@davidcoutadeur davidcoutadeur self-assigned this Nov 4, 2024
@davidcoutadeur davidcoutadeur mentioned this pull request Nov 4, 2024
Closed
@davidcoutadeur
Copy link
Author

davidcoutadeur commented Nov 4, 2024 •
edited
Loading

Drawbacks to discuss:

  • sorting can be different according to the type of attribute
  • hypothesis: for the PR to work, the attribute key of attributes_map hashmap should be the same as the attribute name.

@davidcoutadeur
Copy link
Author

The different types are these ones:

  • ad_date
  • address
  • bytes
  • date
  • dn_link
  • mailto
  • ppolicy_dn
  • tel
  • text

Except for bytes, the asort / arsort functions seem adapted. So I think we can keep the current behavior.

@davidcoutadeur davidcoutadeur merged commit 5d38e70 into master Nov 18, 2024
1 check passed
@davidcoutadeur davidcoutadeur deleted the 171-login-history-descending-order branch November 18, 2024 15:27
@cmaudoux
Copy link

Looks good!

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidcoutadeur davidcoutadeur

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

Append option to sort login history in descending order
2 participants
@davidcoutadeur @cmaudoux