Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename a bunch of things #204

Merged
merged 3 commits into from
Feb 28, 2025
Merged

rename a bunch of things #204

merged 3 commits into from
Feb 28, 2025

Conversation

siliconsniffer
Copy link
Contributor

This PR updates a few references of "minetest" to "luanti" and updates a few links.

@siliconsniffer
Copy link
Contributor Author

siliconsniffer commented Feb 25, 2025 •
edited
Loading

There are a few occurrences where I didn't rename but might need to:

  • for-creators/distrubuting-games-outside-of-contentdb-md: L81
  • for-creators/modding-tips.md: L94+
  • about/faq.md

Does the new luanti-org offer GitHub discussions? If so a few links need to be edited. Wsor confirmed this.
Another thing are the links to display the members, there are a few pointing to the old org - because not everyone got/has moved yet?

@wsor4035
Copy link
Collaborator

by members do you mean people? or other orgs? or what? iirc only c55 has a page?

mark-wiemer
mark-wiemer approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor suggestions :)

@siliconsniffer
Copy link
Contributor Author

siliconsniffer commented Feb 26, 2025 •
edited
Loading

by members do you mean people? or other orgs? or what? iirc only c55 has a page?

I mean people, e.g. the link in git-guidelines.md L52.

Edit: Should the references of minetest in modding-tips.md get renamed to core?

@siliconsniffer siliconsniffer marked this pull request as ready for review February 26, 2025 07:14
wsor4035
wsor4035 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing

wsor4035
wsor4035 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wsor4035 wsor4035 merged commit 07d87b0 into luanti-org:master Feb 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-wiemer mark-wiemer mark-wiemer approved these changes

@appgurueu appgurueu appgurueu left review comments

@wsor4035 wsor4035 wsor4035 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siliconsniffer @wsor4035 @mark-wiemer @appgurueu