Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no squash] Misc. stuff around rotations #15735

Merged
merged 8 commits into from
Feb 27, 2025

Conversation

appgurueu
Copy link
Contributor

@appgurueu appgurueu commented Jan 30, 2025

What the title says. Some tests, some refactoring & improving, made me stumble upon a bug in code I wrote for the glTF loader. See the commits.

@appgurueu appgurueu added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Bugfix 🐛 PRs that fix a bug Code quality labels Jan 30, 2025
@appgurueu appgurueu changed the title Misc. stuff around rotations [no squash] Misc. stuff around rotations Jan 30, 2025
@sfan5 sfan5 added the Rebase needed The PR needs to be rebased by its author label Feb 15, 2025
@sfan5
Copy link
Collaborator

sfan5 commented Feb 15, 2025

rebase needed

@appgurueu appgurueu removed the Rebase needed The PR needs to be rebased by its author label Feb 23, 2025
Copy link
Collaborator

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfan5 sfan5 merged commit 90121dc into luanti-org:master Feb 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug Code quality Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants