Support serving non-root manifest #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldenstein64
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for pulling non-root manifest files from
/m/:manifest/manifest.Fixes #59. Also fixes #141.
I should add that I'm very inexperienced in using Lapis and web dev in general, so I would like confirmation that I'm not breaking the API, creating a bad performance path, adding code in the wrong file, etc.
I'm afraid this could complicate mirrors or other things because all invalid non-root manifest URLs, even if said manifest is fake, redirect to
/*. If this causes difficulties, I'm happy to change/remove it.