Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-nullable reference types #2

Merged
merged 16 commits into from
Jul 16, 2024
Merged

Conversation

luboshl
Copy link
Owner

@luboshl luboshl commented Jul 14, 2024

  • Add support of non-nullable reference types the same way as ASP.NET Core MVC model binding does.
    • Non-nullable reference type behave the same way as it has [Required] attribute - validation fails when the property value is null.
  • Fix duplicate validation error messages for the the same field.
  • Optimize visiting of enumerable types - exclude string type.
  • Add some other complex types to exclude recursion
    • Uri used in tests failed because it has non-nullable reference properties with getter that failed in test cases used in unit tests.
    • Similar exclusion is used in ASP.NET Core - see lines 122-135 in MvcCoreMvcOptionsSetup.cs

@luboshl luboshl linked an issue Jul 14, 2024 that may be closed by this pull request
@luboshl luboshl self-assigned this Jul 14, 2024
@luboshl luboshl merged commit 2b2d663 into main Jul 16, 2024
1 check passed
@luboshl luboshl deleted the feature/non-nullable-reference-types branch July 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-nullable reference types
1 participant