This repository has been archived by the owner on Dec 1, 2017. It is now read-only.
Fixed bug with height in horizontal mode #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TwoWayView is set to horizontal mode and layout_height="wrap_content" the view would consume all available space on the screen. Esentially ignoring the wrap_content flag. When in wrap_content mode the view should only take up the nessecary space to show it's contents.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a TwoWayView is set to horizontal mode and is using layout_height="wrap_content"
the view consumes all available space on the screen. Essentially ignoring the wrap_content flag.
When in wrap_content mode the view should only take up the necessary space to show it's contents.
This is the same bug as described in issue #22
Issues #35 and #63 maybe related to this change.
This change will in-effect make TwoWayView deal with wrap_content correctly.
It will set it's height to the height of it's largest child in horizontal mode.
And in vertical mode it will set the width to the width of the widest child.