Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 3 commits into
base: feedback
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[![Open in Visual Studio Code](https://classroom.github.com/assets/open-in-vscode-718a45dd9cf7e7f842a935f5ebbe5719a5e09af4491e668f4dbf3b35d5cca122.svg)](https://classroom.github.com/online_ide?assignment_repo_id=13574649&assignment_repo_type=AssignmentRepo)
[![Java sbt CI](https://github.com/lucformalmethodscourse/hello-java-sbt/actions/workflows/java-sbt.yml/badge.svg)](https://github.com/lucformalmethodscourse/hello-java-sbt/actions/workflows/java-sbt.yml)

This build will always fail because it has 2 examples of failing tests:
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/hw/HelloWorld.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ public String getMessage() {
}

public int getYear() {
return 2017;
return 2024;
}
}
6 changes: 0 additions & 6 deletions src/test/java/hw/TestHelloWorld.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ public void getMessage() {
assertEquals("hello world", fixture.getMessage());
}

@Test
public void getMessage2() { // this test is broken - fix it!
assertNull(fixture);
assertEquals("hello world", fixture.getMessage());
}

@Test
public void getYear() { // this test is OK, fix HelloWorld.java to make it pass!
assertNotNull(fixture);
Expand Down
Loading