Don't return ref to private member

lucianposton · May 16, 2017 · 98e6c48 · 98e6c48
1 parent 3294652
commit 98e6c48
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/zonemgr.h b/src/zonemgr.h
@@ -40,8 +40,8 @@ class ZoneMgr : public QObject
   QString zoneNameFromID(uint16_t zoneId);
   QString zoneLongNameFromID(uint16_t zoneId);
   bool isZoning() const { return m_zoning; }
-  const QString& shortZoneName() const { return m_shortZoneName; }
-  const QString& longZoneName() const { return m_longZoneName; }
+  QString shortZoneName() const { return m_shortZoneName; }
+  QString longZoneName() const { return m_longZoneName; }
   const Point3D<int16_t>& safePoint() const { return m_safePoint; }
   float zoneExpMultiplier() { return m_zone_exp_multiplier; }
   const zonePointStruct* zonePoint(uint32_t zoneTrigger);