Edit login user functions to return the User
#1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3e77d3a.
michplunkett
commented
Aug 7, 2023
| @@ -336,7 +338,6 @@ def test_admin_approval_sends_confirmation_email( | |||
| session, | |||
| ): | |||
| current_app.config["APPROVE_REGISTRATIONS"] = approve_registration_config | |||
| EmailClient(testing=True) | |||
There was a problem hiding this comment.
This has been moved to a test fixture.
michplunkett
commented
Aug 7, 2023
Comment on lines
+105
to
+107
| def test_job_repr(mockdata): | ||
| job = Job.query.first() | ||
| assert repr(job) == f"<Job ID {job.id}: {job.job_title}>" |
There was a problem hiding this comment.
I saw the test was missing so I added it.
michplunkett
requested review from
b-meson,
AetherUnbound,
abandoned-prototype and
null-space-0
b-meson
approved these changes
Aug 7, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
lucyparsons#1010 Edit the `login_user` functions so that they return the user (removing the need for an extra database query) and create constants for the login values. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
lucyparsons#1010 Edit the `login_user` functions so that they return the user (removing the need for an extra database query) and create constants for the login values. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
lucyparsons#1010 Edit the `login_user` functions so that they return the user (removing the need for an extra database query) and create constants for the login values. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
lucyparsons#1010 Edit the `login_user` functions so that they return the user (removing the need for an extra database query) and create constants for the login values. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#1010
Description of Changes
Edit the
login_userfunctions so that they return the user (removing the need for an extra database query) and create constants for the login values.Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.