Replace X links with Bluesky links #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
requested review from
b-meson,
AetherUnbound,
abandoned-prototype and
sea-kelp
michplunkett
commented
Nov 22, 2024
Comment on lines
165
to
166
| dept_selector = Select(browser.find_element_by_id("dept")) | ||
| uii_element = browser.find_element_by_id("uii-question") | ||
| dept_selector = Select(browser.find_element(By.ID, "dept")) | ||
| uii_element = browser.find_element(By.ID, "uii-question") |
There was a problem hiding this comment.
Before this change, the the build was failing on the 3.12 version tests.
|
There's some issue with the v3.12 tests. I'll get this addressed within the next 48 hours or so. |
b-meson
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Since we killed the X link and are focusing on using Bluesky, I updated the site to reflect that. We did need to update the font awesome version so that it had access to the Bluesky image.
Screenshots (if appropriate)
Before:
After:
Tests and Linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.