-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add occurred_at
column
#992
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I had a much simpler understanding of this and was thinking of this as if we were handing the backend a UTC timestamp. I am modifying this PR a good amount. I'll reach out when it's good. |
michplunkett
changed the title
Change incidents
Remove incidents Aug 7, 2023
time
and date
columns to occurred_at
time
and add occurred_at
column
I'm gonna knock this one out on Monday when my mind is a little clearer. |
michplunkett
changed the title
Remove incidents
Add Aug 16, 2023
time
and add occurred_at
columnoccurred_at
column
I'm gonna restart this feature in the following PR: #1024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#980
Description of Changes
When both the
time
anddate
fields are filled in, we migrate them to theoccurred_at
column which is stored in UTC.Screenshots
Before migration:
After initial
upgrade
:After
downgrade
:Final
upgrade
:Incident listing:
Tests and linting
develop
branch.pytest
passes on my local development environment.pre-commit
passes on my local development environment.DB Migration Output