Silex provider #16
Silex provider #16
Conversation
…n is required by http-kernel and config/dependency-injection is not needed if only using bundle in silex context
- Move JS files that need to be loaded into resources so we can include them in the template. This is required for silex - Add silex service provider Still need to figure out a way to load the font files that are needed when outside of the Symfony bundle structure.
ghost
assigned 
|
I'm reviewing this asap, thanks a lot. |
|
Sounds good. Let me know your thoughts on loading of the fonts since we have to handle it a little differently with Silex based applications. It will probably require some configuration I'm thinking. |
|
Actually I never used the web profiler from Symfony on Silex. I have to try
|
|
Correct. This means that we don't know where these assets will live on the web server |
|
Hey, so my question is: is this a common practice to include silex provider in a bundle ? I have a solution which is actually provide a post composer script to dump the assets in a configured path... But it would be extra hackish and since there is no hard convention in silex, it would require an user input. The other solution is to actually separate this provider in another repo with a composer dependecy to this bundle. Then we could add a script/command to dump the assets. |
|
I'm not sure what the best practice is. As long as the other repo is referenced within this one so that developers easily see it exist I'm sure it would be fine to live on it's own. |
|
Ok, let's do this. I'll reference it in the readme 👍 |
|
Be aware that this bundle could be merged into this one: misd-service-development/guzzle-bundle#29 |
|
Great to see the merging of the bundles happening! |
This pull requests allows integration to the guzzle data collector with Silex. Documentation on usage is slim right now and no tests have been done.
One thing that still needs to be done and needs discussion is how to load the font files that are needed since we can not use the "asset" filter.