Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octeon: Add Cavium Octeon driver support #731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

octeon: Add Cavium Octeon driver support #731

wants to merge 1 commit into from

Conversation

carlgsmith
Copy link
Contributor

No description provided.

jhk098
jhk098 reviewed Oct 3, 2020
View reviewed changes
LINUX/octeon_netmap.h Outdated
for (i = 0; i <= nma_get_nrings(na, t); i++) {
struct netmap_kring *kring = NMR(na, t)[i];
if (nm_kring_pending_on(kring)) {
kring->nr_mode = NKR_NETMAP_ON;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For hardware NICs, this operation is usually performed by calling netmap_reset from the driver patch. You can look at intel drivers, for example, or vmxnet3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

jhk098
jhk098 reviewed Oct 3, 2020
View reviewed changes
LINUX/octeon_netmap.h Outdated
for (i = 0; i <= nma_get_nrings(na, t); i++) {
struct netmap_kring *kring = NMR(na, t)[i];
if (nm_kring_pending_off(kring)) {
kring->nr_mode = NKR_NETMAP_OFF;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@carlgsmith
Copy link
Contributor Author

Have also updated patch to include NAF_OFFSETS support for Octeon

@giuseppelettieri
Copy link
Collaborator

giuseppelettieri commented Jan 29, 2021 •
edited
Loading

Hi, sorry for the late reply. We are more than willing to merge this, but vanilla patches are auto-generated from a different repository which is a clone of vanilla linux. You find a copy of the repo here: https://github.com/giuseppelettieri/linux-pspat. There is a netmap-$v branch for each version of linux. You should remove the vanilla--octeon--* file from this pull request and create a pull request for the other repo, containing only the necessary changes for the driver. You can target any one of the netmap-$v branches. I will then try to forward/backword port the commit as much as possible and then auto-generate the patch for the netmap repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhk098 jhk098 jhk098 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlgsmith @giuseppelettieri @jhk098