Use a more commonly supported character for fat_headline_lower_string

[davidstosik]

Update: this PR now uses matching "Upper Half Block" and "Lower Half Block" to generate vertically centered half headlines.

What

This PR replaces the character 🬂 (Block Sextant-12 (U+1FB02)) with ▀ (Upper Half Block (U+2580)) to be used for the fat_headline_lower_string configuration everywhere.

Why

The Block Sextant-12 character is part of a Unicode block named Symbols for Legacy Computing.
(Emphasis on "legacy" mine. 😬)

This character seems to not be supported by a lot of fonts and many terminals, as well as other applications (one might even see a "missing character" square while browsing this PR and links I provided).

I have for example confirmed that it would not work with the following:

• Terminal apps:
  • macOS' Terminal.app
  • iTerm2
  • Alacritty with builtin_box_drawing set to false
• Fonts:
  • Monaco
  • MonaspiceNe Nerd Font
  • SFMono Nerd Font
  • Fira Code Nerd Font

Upper Half Block is slightly thicker than Block Sextant-12, but it also appears to be more widely supported across terminals and fonts.

I think a default configuration that will work in most environments would provide a better user experience, and would likely prevent many developers from spending hours diving into the unknown territories of font rendering, Unicode blocks, NeoVim LUA configuration, etc.

How

A simple script that replaces all instances of the Block Sextant-12 character in the repository:

 ag -l \U0001fb02 | xargs -n1 sed -i '' -e "s/\U0001fb02/▀/"

Anything else?

Alternative

An alternative to Upper Half Block would be the thinner ▔ (Upper One Eighth Block (U+2594)).

Matching "lower" and "upper"

If it is important for the width of the fat headline top and bottom padding be identical, then we could also change fat_headline_upper_string to use a character of the same width.
Respectively, in order of appearance above:

• ▄ (Lower Half Block (U+2584))
• ▁ (Lower One Eighth Block (U+2581))

Screenshots

Using the evening colorscheme, iTerm2 with MonaspiceNe Nerd Font.

What	Screenshot
Before
This PR
Alt: upper one eighth
Alt: matching half blocks
Alt: matching 1/8 blocks

[davidstosik]

For reference:

• strange question mark icons below headings in markdown file - lazyvim
• Weird graphical problems #38
• Gaps within the fat headlines #36
• fat_headline_lower_string not working #61
• "Flickering" and missing headlines #41 (comment)

[davidstosik]

And a proof that most fonts don't support Block Sextant-12: copy the first paragraph in my PR description above, paste it in https://www.programmingfonts.org/#firacode, then scroll through fonts.

---

Or even just do it in any text editor, like for example macOS' TextEdit:

---

(You can check out Google Fonts too.)

[davidstosik]

TIL that macOS' Font Book can search fonts by supported characters.

🬂 (Block Sextant-12)	▀ (Upper Half Block)

[davidstosik]

Here's a final comment: Nerd Fonts don't seem to be designed to add a glyph for the block sextant-12 character code, so it'll boil down to whether the original, unpatched font supported it to begin with.

[davidstosik]

@lukas-reineke Pinging you in case you've missed this. 🙏🏻

[lukas-reineke]

Sorry for the delay.
I'm not against changing this, but I think top and bottom should match, so your matching half blocks example is probably best.

[davidstosik]

@lukas-reineke Done. 999ad2e

[lukas-reineke]

Thanks

[davidstosik]

Just out of curiosity, why not merge the PR?
Now GitHub isn't able to link the commit (bf17c96) back to this PR, which I think is a shame, as that's lost context...

Just curious really.

[lukas-reineke]

I just had to change the commit message to include a breaking change notification.
The PR is still linked in the release notes.