Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added language: risor #800

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

applejag
Copy link
Contributor

Adds language risor: https://risor.io/

I'm currently creating a tree-sitter grammar for it: https://github.com/applejag/tree-sitter-risor

Took me a while of debugging why the scope feature didn't work out-of-the box. I thought for so long that my grammar was wrong 😅 never considered that it was ibl

I was not able to add the language just from configs though. Would've been nice if that was possible. But currently ibl just skips if it does not contian the language in its hardcoded list:

local lang = lang_tree:lang()
if not scope_lang[lang] then
return nil
end

Copy link
Owner

@lukas-reineke lukas-reineke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
Code looks fine, but can you use conventional commit messages, please?

I was not able to add the language just from configs though. Would've been nice if that was possible. But currently ibl just skips if it does not contian the language in its hardcoded list:

I thought about adding an option for this, but decided against it. It should be rare that someone adds a whole new language. And in case they do, I want to encourage them to make a PR, like you are now. Then it will work out of the box for everyone else.

@applejag
Copy link
Contributor Author

And in case they do, I want to encourage them to make a PR, like you are now.

Ohohoh you sneaky fella. It sure worked!

@applejag applejag force-pushed the feature/add-lang-risor branch from 08a9317 to 59e4ff2 Compare December 19, 2023 11:06
@lukas-reineke lukas-reineke merged commit 38cd858 into lukas-reineke:master Dec 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants