Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dart:async import #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelRFairhurst
Copy link

This is unused from Dart 2.1 and on when dart:core exports Future/Stream

This is unused from Dart 2.1 and on when dart:core exports Future/Stream
@MichaelRFairhurst
Copy link
Author

ping @lukasgit

@MichaelRFairhurst
Copy link
Author

Ping once more @lukasgit :)

@lukasgit
Copy link
Owner

lukasgit commented Oct 1, 2020

I'm sorry for the delay. I lost two very special people in my life. One a couple of months ago, the other two days ago. I'm back and will work on your PR over the weekend. Thanks for your patience and understanding.

@MichaelRFairhurst
Copy link
Author

Wow, that sounds horrible Lukas. :(

I will happily and patiently wait, if you do find time over this weekend I'll be super grateful, and if you don't for any reason, I will be 100% understanding. Wish you the best in the grief process, and that's more important than this PR.

@imaNNeo
Copy link
Collaborator

imaNNeo commented Nov 11, 2020

Hi. I am pleased to review your code.
I think there is a lot of format change in your PR.
You can make a separate PR to format the code. Let's keep this PR responsible for what you mentioned in the title (Remove unused dart:async import).

It makes PRs clear to follow up. BTW I think we don't have any formatting rule in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants