[Contact service android] Split the projection for contact info. Allow apps to configure the contact info they wants. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukasgit Hi Lukas, can you take a look at this PR? |
|
@zhenqiu1101 will do, thanks |
Apologies for the delay @zhenqiu1101 . Is this PR tested are ready? Is there anything instructions needed to be added to the readme ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querying all contact columns results in the error: "Row too big to fit into CursorWindow". That is because some columns are referring to the same internal column (data1, data2 .... data6 etc). We get duplicate columns for single row. So we split the cursors for querying different contact info. Add an optional parameter for apps to configure what contact info they wants.