feat: save public key or its ID to secretFileData #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2024 13:28
alxndr13
changed the title
alxndr13
force-pushed
the
feat-add-public-key-to-secrets
branch
from
91eb5ce to
60ef55d
Compare
alxndr13
force-pushed
the
feat-add-public-key-to-secrets
branch
from
60ef55d to
0983873
Compare
|
@lukasjarosch PR is now ready, PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our Project where we use skipper, we want to implement a feature where re-encryption of secrets is possible using a single command.
In our best-case scenario, we want to be able to replace the key in the inventory and let our project's CLI do the rest. But this means we have to know which was the OLD key and which is the NEW one, we want to re-encrypt our secrets with.
This change saves the "Public Key" (there's no such driver as of this PR, which uses a public key) or a Key Identifier (azurekv) to enable skipper to know which secret got encrypted with which key.