This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
remove room #74
Open
remove room #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
YashZolmajdi
reviewed
Jan 9, 2019
| </li> | ||
| ))} | ||
| </ul> | ||
| <div> |
YashZolmajdi
reviewed
Jan 9, 2019
| @@ -54,7 +54,12 @@ class View extends React.Component { | |||
| this.actions.scrollToEnd() | |||
| }, | |||
|
|
|||
| removeRoom: room => this.setState({ room: {} }), | |||
| removeRoom: room => { | |||
YashZolmajdi
reviewed
Jan 9, 2019
| @@ -221,7 +226,7 @@ class View extends React.Component { | |||
| sidebarOpen, | |||
| userListOpen, | |||
| } = this.state | |||
| const { createRoom, createConvo, removeUserFromRoom } = this.actions | |||
| const { createRoom, createConvo/*, removeUserFromRoom*/ } = this.actions | |||
There was a problem hiding this comment.
remove commented code or add todo comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looking at #68 , I (tentatively) implemented a leave room button (I'm open to suggestions for a more aesthetic appearance and/orlocation) as shown
However, it doesn't update the room list on the right until another action's been taken
(Also noted that I don't think removeUserFromRoom is implemented properly or used in any context currently, so if anyone could help me out with this + concurrently updating the room that'd be great - otherwise I'll try to figure it out in the meantime)