Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): add support for isSelected in low emphasis #1225

Merged

Conversation

gcornut
Copy link
Member

@gcornut gcornut commented Dec 4, 2024

  • Reworked button styles so that the selected state can apply on top of both medium and low emphasis
  • Deprecate selected state padding variables as we prefer to keep the base emphasis style for sizing

Selected state in low and medium emphasis is testable here: https://4436b6bb--5fbfb1d508c0520021560f10.chromatic.com/?path=/story/lumx-components-button-button--state-variations

StoryBook: https://1e0d3d2e--5fbfb1d508c0520021560f10.chromatic.com/ (Chromatic build) ⚠️ Outdated commit

@gcornut gcornut force-pushed the feat_button_add_support_for_isselected_in_low_emphasis branch 4 times, most recently from a36656c to 4436b6b Compare December 6, 2024 13:48
@gcornut gcornut marked this pull request as ready for review December 6, 2024 16:38
@gcornut gcornut requested review from lumautomation and a team as code owners December 6, 2024 16:38
@gcornut gcornut force-pushed the feat_button_add_support_for_isselected_in_low_emphasis branch from 4436b6b to 1e0d3d2 Compare December 7, 2024 07:04
@gcornut gcornut force-pushed the feat_button_add_support_for_isselected_in_low_emphasis branch from 1e0d3d2 to d25f68a Compare December 9, 2024 15:11
@gcornut
Copy link
Member Author

gcornut commented Dec 9, 2024

Test OK
(tested in product directly)
Button medium selected work like before ✅
Button low selected work like before ✅ (but future proofed for the change on the border of the selected state)
(tested on product components: v1 follow button, wrex toolbar elements, v2 follow button)
Date picker selected date ✅ (basically a button low selected)

@gcornut gcornut merged commit 15d2126 into master Dec 10, 2024
8 checks passed
@gcornut gcornut deleted the feat_button_add_support_for_isselected_in_low_emphasis branch December 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants